Skip to content

Remove unsupported characters in Pypi from_native implementation - #57

Merged
TG1999 merged 2 commits into
aboutcode-org:mainfrom
TG1999:fix/pypi_version_range_unsupported_characters
Apr 5, 2022
Merged

Remove unsupported characters in Pypi from_native implementation#57
TG1999 merged 2 commits into
aboutcode-org:mainfrom
TG1999:fix/pypi_version_range_unsupported_characters

Conversation

@TG1999

@TG1999 TG1999 commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Remove unsupported characters in Pypi from_native implementation

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

Remove unsupported characters in Pypi from_native implementation

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 changed the title Reference: https://github.com/nexB/univers/issues/48 Remove unsupported characters in Pypi from_native implementation Mar 31, 2022

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hritik14

Hritik14 commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

LGTM as well. While you are at it, how about adding the known version examples to https://github.com/nexB/univers/blob/e400e23150685ce1fa585e5d407d7b6a37fa5a89/tests/test_version_range.py#L282-L286

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 merged commit 951c137 into aboutcode-org:main Apr 5, 2022
TG1999 pushed a commit to TG1999/univers that referenced this pull request May 10, 2022
Deprecate windows-2016 images for azure CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants